chore: drop status go ethereum fork #6961

dlipicar · 2025-09-26T21:04:52Z

status-desktop PR for testing: status-im/status-desktop#18960

Blocked by:

This PR drops use of our infamous go-ethereum fork (https://github.com/status-im/go-ethereum).
status-go will after this be using the original one (https://github.com/ethereum/go-ethereum).

Much work was done by many folks to get status-go to a state where it stops relying on our changes on top of the go-ethereum version we used as base: ethereum/go-ethereum@master...status-im:go-ethereum:release/v1.10.25-status

Much additional work was done to adapt to the changes between geth v1.10.25 and v1.16.3

This PR includes the final changes missing which mostly cannot be introduced without changing the geth version at the same time.

status-im-auto · 2025-09-26T21:07:15Z

Jenkins Builds

Click to see older builds (94)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
❌	`7152777`	#1	2025-09-26 21:07:15	~2 min	`macos/status-go`	📄`log`
❌	`7152777`	#1	2025-09-26 21:07:19	~2 min	`linux/status-go`	📄`log`
✖️	`7152777`	#1	2025-09-26 21:08:47	~3 min	`tests`	📄`log`
❌	`7152777`	#2	2025-09-26 21:09:21	~1 min	`macos/status-go`	📄`log`
❌	`7152777`	#2	2025-09-26 21:09:41	~2 min	`linux/status-go`	📄`log`
❌	`7152777`	#1	2025-09-26 21:09:48	~4 min	`windows/status-go`	📄`log`
✔️	`7152777`	#1	2025-09-26 21:15:14	~9 min	`tests-rpc`	📄`log`
❌	`7152777`	#1	2025-09-26 21:15:26	~10 min	`linux/nwaku`	📄`log`
❌	`7152777`	#2	2025-09-26 21:25:12	~9 min	`linux/nwaku`	📄`log`
✔️	`7152777`	#2	2025-09-26 21:25:14	~9 min	`tests-rpc`	📄`log`

❌	`825fc3e`	#3	2025-10-01 14:57:35	~1 min	`linux/status-go`	📄`log`
❌	`825fc3e`	#3	2025-10-01 14:57:39	~1 min	`macos/status-go`	📄`log`
❌	`825fc3e`	#2	2025-10-01 15:00:33	~4 min	`windows/status-go`	📄`log`
❌	`825fc3e`	#3	2025-10-01 15:06:18	~10 min	`linux/nwaku`	📄`log`
✖️	`825fc3e`	#3	2025-10-01 15:12:18	~16 min	`tests-rpc`	📄`log`
✖️	`825fc3e`	#2	2025-10-01 15:15:19	~19 min	`tests`	📄`log`

❌	`8ac1d9e`	#4	2025-10-01 15:06:35	~2 min	`macos/status-go`	📄`log`
❌	`8ac1d9e`	#3	2025-10-01 15:09:13	~4 min	`windows/status-go`	📄`log`
❌	`8ac1d9e`	#4	2025-10-01 15:17:54	~13 min	`linux/status-go`	📄`log`
❌	`8ac1d9e`	#4	2025-10-01 15:27:22	~21 min	`linux/nwaku`	📄`log`
✖️	`8ac1d9e`	#4	2025-10-01 15:32:35	~20 min	`tests-rpc`	📄`log`
✖️	`8ac1d9e`	#3	2025-10-01 15:34:12	~18 min	`tests`	📄`log`

❌	`64516e8`	#5	2025-10-01 15:28:48	~3 min	`macos/status-go`	📄`log`
❌	`64516e8`	#4	2025-10-01 15:30:19	~4 min	`windows/status-go`	📄`log`
❌	`64516e8`	#5	2025-10-01 15:54:32	~29 min	`linux/status-go`	📄`log`
❌	`64516e8`	#5	2025-10-01 16:03:27	~36 min	`linux/nwaku`	📄`log`
✖️	`64516e8`	#4	2025-10-01 16:06:38	~32 min	`tests`	📄`log`
✖️	`64516e8`	#5	2025-10-01 16:07:22	~34 min	`tests-rpc`	📄`log`

❌	`391a815`	#6	2025-10-01 21:39:46	~1 min	`macos/status-go`	📄`log`
❌	`391a815`	#6	2025-10-01 21:40:10	~2 min	`linux/status-go`	📄`log`
❌	`391a815`	#5	2025-10-01 21:42:33	~4 min	`windows/status-go`	📄`log`
✖️	`391a815`	#5	2025-10-01 21:42:37	~4 min	`tests`	📄`log`
✖️	`391a815`	#6	2025-10-01 21:44:08	~6 min	`tests-rpc`	📄`log`
❌	`391a815`	#6	2025-10-01 21:47:53	~10 min	`linux/nwaku`	📄`log`

❌	`2f71258`	#7	2025-10-01 21:41:38	~1 min	`macos/status-go`	📄`log`
❌	`2f71258`	#7	2025-10-01 21:43:34	~3 min	`linux/status-go`	📄`log`
❌	`2f71258`	#6	2025-10-01 21:47:01	~4 min	`windows/status-go`	📄`log`
✖️	`2f71258`	#6	2025-10-01 21:48:41	~5 min	`tests`	📄`log`
✖️	`2f71258`	#7	2025-10-01 21:52:42	~8 min	`tests-rpc`	📄`log`
❌	`2f71258`	#7	2025-10-01 21:57:01	~8 min	`linux/nwaku`	📄`log`

❌	`79d2d46`	#8	2025-10-02 12:09:07	~1 min	`macos/status-go`	📄`log`
❌	`79d2d46`	#7	2025-10-02 12:11:40	~4 min	`windows/status-go`	📄`log`
❌	`79d2d46`	#8	2025-10-02 12:13:22	~6 min	`linux/status-go`	📄`log`
✖️	`79d2d46`	#7	2025-10-02 12:20:10	~12 min	`tests`	📄`log`
✖️	`79d2d46`	#8	2025-10-02 12:21:53	~14 min	`tests-rpc`	📄`log`
❌	`79d2d46`	#8	2025-10-02 12:22:38	~15 min	`linux/nwaku`	📄`log`

❌	`17f7c1a`	#9	2025-10-02 16:28:18	~2 min	`macos/status-go`	📄`log`
❌	`17f7c1a`	#9	2025-10-02 16:28:39	~2 min	`linux/status-go`	📄`log`
❌	`17f7c1a`	#8	2025-10-02 16:31:03	~4 min	`windows/status-go`	📄`log`
✖️	`17f7c1a`	#8	2025-10-02 16:31:41	~5 min	`tests`	📄`log`
❌	`17f7c1a`	#9	2025-10-02 16:36:15	~10 min	`linux/nwaku`	📄`log`
✔️	`17f7c1a`	#9	2025-10-02 16:38:47	~12 min	`tests-rpc`	📄`log`

❌	`3e24920`	#10	2025-10-02 16:47:17	~1 min	`macos/status-go`	📄`log`
❌	`3e24920`	#10	2025-10-02 16:48:16	~2 min	`linux/status-go`	📄`log`
❌	`3e24920`	#9	2025-10-02 16:49:45	~4 min	`windows/status-go`	📄`log`
✖️	`3e24920`	#9	2025-10-02 16:51:56	~6 min	`tests`	📄`log`
❌	`3e24920`	#10	2025-10-02 16:56:52	~11 min	`linux/nwaku`	📄`log`
✔️	`3e24920`	#10	2025-10-02 16:59:04	~13 min	`tests-rpc`	📄`log`

❌	`c7a8bfa`	#11	2025-10-03 11:49:42	~3 min	`linux/status-go`	📄`log`
❌	`c7a8bfa`	#11	2025-10-03 11:50:19	~4 min	`macos/status-go`	📄`log`
❌	`c7a8bfa`	#10	2025-10-03 11:51:09	~4 min	`windows/status-go`	📄`log`
✖️	`c7a8bfa`	#10	2025-10-03 11:54:31	~8 min	`tests`	📄`log`
❌	`c7a8bfa`	#11	2025-10-03 11:58:24	~12 min	`linux/nwaku`	📄`log`
✔️	`c7a8bfa`	#11	2025-10-03 11:59:57	~13 min	`tests-rpc`	📄`log`

✔️	`0ec75ce`	#12	2025-10-03 14:18:11	~4 min	`macos/status-go`	📦`zip`
✔️	`0ec75ce`	#11	2025-10-03 14:20:57	~6 min	`windows/status-go`	📦`zip`
✔️	`0ec75ce`	#12	2025-10-03 14:33:33	~19 min	`linux/status-go`	📦`zip`
✔️	`0ec75ce`	#12	2025-10-03 14:37:29	~23 min	`linux/nwaku`	📦`zip`
✖️	`0ec75ce`	#11	2025-10-03 14:39:16	~25 min	`tests`	📄`log`
✔️	`0ec75ce`	#12	2025-10-03 14:44:41	~30 min	`tests-rpc`	📄`log`

✔️	`5029829`	#13	2025-10-03 18:31:11	~3 min	`linux/status-go`	📦`zip`
✔️	`5029829`	#13	2025-10-03 18:31:24	~3 min	`macos/status-go`	📦`zip`
✖️	`5029829`	#12	2025-10-03 18:34:37	~7 min	`tests`	📄`log`
✔️	`5029829`	#12	2025-10-03 18:35:07	~7 min	`windows/status-go`	📦`zip`
✔️	`5029829`	#13	2025-10-03 18:39:05	~11 min	`tests-rpc`	📄`log`
✔️	`5029829`	#13	2025-10-03 18:39:12	~11 min	`linux/nwaku`	📦`zip`

✔️	`4c84b1c`	#14	2025-10-03 20:43:34	~3 min	`macos/status-go`	📦`zip`
✔️	`4c84b1c`	#14	2025-10-03 20:44:06	~4 min	`linux/status-go`	📦`zip`
✔️	`4c84b1c`	#13	2025-10-03 20:48:45	~8 min	`windows/status-go`	📦`zip`
✖️	`4c84b1c`	#13	2025-10-03 20:49:12	~9 min	`tests`	📄`log`
✔️	`4c84b1c`	#14	2025-10-03 20:50:49	~10 min	`tests-rpc`	📄`log`
✔️	`4c84b1c`	#14	2025-10-03 20:51:08	~11 min	`linux/nwaku`	📦`zip`

✔️	`c7131e1`	#15	2025-10-03 23:28:23	~3 min	`macos/status-go`	📦`zip`
✔️	`c7131e1`	#15	2025-10-03 23:30:27	~5 min	`linux/status-go`	📦`zip`
✔️	`c7131e1`	#14	2025-10-03 23:33:44	~8 min	`windows/status-go`	📦`zip`
✔️	`c7131e1`	#15	2025-10-03 23:40:51	~15 min	`linux/nwaku`	📦`zip`
✔️	`c7131e1`	#15	2025-10-03 23:42:27	~17 min	`tests-rpc`	📄`log`
✔️	`c7131e1`	#14	2025-10-03 23:59:02	~34 min	`tests`	📄`log`
✔️	`c7131e1`	#16	2025-10-06 14:31:57	~4 min	`linux/status-go`	📦`zip`
✔️	`c7131e1`	#16	2025-10-06 14:32:01	~4 min	`macos/status-go`	📦`zip`
✔️	`c7131e1`	#15	2025-10-06 14:35:45	~7 min	`windows/status-go`	📦`zip`
✔️	`c7131e1`	#16	2025-10-06 14:38:21	~10 min	`tests-rpc`	📄`log`
✔️	`c7131e1`	#16	2025-10-06 14:38:25	~10 min	`linux/nwaku`	📦`zip`
✔️	`c7131e1`	#15	2025-10-06 14:55:05	~27 min	`tests`	📄`log`

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`a54b7fb`	#17	2025-10-06 14:37:33	~5 min	`macos/status-go`	📦`zip`
✔️	`a54b7fb`	#17	2025-10-06 14:39:57	~7 min	`linux/status-go`	📦`zip`
✔️	`a54b7fb`	#16	2025-10-06 14:43:42	~7 min	`windows/status-go`	📦`zip`
✔️	`a54b7fb`	#17	2025-10-06 14:49:15	~10 min	`linux/nwaku`	📦`zip`
✔️	`a54b7fb`	#17	2025-10-06 14:49:29	~10 min	`tests-rpc`	📄`log`
✖️	`a54b7fb`	#16	2025-10-06 15:22:35	~27 min	`tests`	📄`log`

✔️	`241278c`	#18	2025-10-06 15:12:28	~3 min	`linux/status-go`	📦`zip`
✔️	`241278c`	#18	2025-10-06 15:13:48	~5 min	`macos/status-go`	📦`zip`
✔️	`241278c`	#17	2025-10-06 15:17:21	~8 min	`windows/status-go`	📦`zip`
✖️	`241278c`	#18	2025-10-06 15:18:35	~9 min	`tests-rpc`	📄`log`
✔️	`241278c`	#18	2025-10-06 15:20:37	~12 min	`linux/nwaku`	📦`zip`
✖️	`241278c`	#19	2025-10-06 15:32:10	~10 min	`tests-rpc`	📄`log`
✔️	`241278c`	#17	2025-10-06 15:54:13	~31 min	`tests`	📄`log`
✔️	`241278c`	#20	2025-10-06 16:50:45	~10 min	`tests-rpc`	📄`log`

codecov · 2025-09-26T21:25:39Z

Codecov Report

❌ Patch coverage is 64.86486% with 208 lines in your changes missing coverage. Please review.
✅ Project coverage is 59.39%. Comparing base (3386609) to head (c7131e1).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines	Patch %	Lines
services/wallet/reader.go	52.10%	53 Missing and 4 partials ⚠️
...rvices/wallet/collectibles/ownership/controller.go	54.11%	34 Missing and 5 partials ⚠️
rpc/chain/client.go	12.90%	27 Missing ⚠️
services/wallet/multistandardbalance_adaptors.go	41.86%	20 Missing and 5 partials ⚠️
services/wallet/blockchainstate/blockchainstate.go	74.15%	20 Missing and 3 partials ⚠️
logutils/geth_adapter.go	65.11%	15 Missing ⚠️
services/wallet/wallettypes/types.go	0.00%	7 Missing ⚠️
services/wallet/collectibles/contract_type_db.go	61.53%	4 Missing and 1 partial ⚠️
services/wallet/router/fees/estimated_time.go	0.00%	4 Missing ⚠️
logutils/lvl_from_string.go	87.50%	2 Missing ⚠️
... and 2 more

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #6961      +/-   ##
===========================================
+ Coverage    55.44%   59.39%   +3.94%     
===========================================
  Files          833      823      -10     
  Lines       120101   116697    -3404     
===========================================
+ Hits         66595    69315    +2720     
+ Misses       46535    40274    -6261     
- Partials      6971     7108     +137

Flag	Coverage Δ
functional	`33.89% <52.19%> (?)`
unit	`55.14% <58.27%> (-0.31%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
logutils/logger.go	`100.00% <100.00%> (ø)`
node/rpc/rpc.go	`83.33% <100.00%> (+2.08%)`	⬆️
node/status_node_services.go	`78.84% <100.00%> (+0.08%)`	⬆️
rpc/chain/ethclient/eth_client.go	`1.34% <ø> (+0.25%)`	⬆️
services/connector/api.go	`76.59% <100.00%> (+5.62%)`	⬆️
services/connector/commands/send_transaction.go	`51.31% <100.00%> (+27.26%)`	⬆️
services/connector/commands/test_helpers.go	`100.00% <100.00%> (ø)`
services/connector/service.go	`87.09% <100.00%> (+19.88%)`	⬆️
services/connector/test_helpers.go	`100.00% <100.00%> (ø)`
services/wallet/activity/session_service.go	`73.87% <ø> (+37.33%)`	⬆️
... and 18 more

... and 207 files with indirect coverage changes

igor-sirotin · 2025-10-02T16:38:41Z

I've checked once again the verifyTransactionLoop
Here's what we do every 30 seconds:

status-go/services/ext/service.go

Line 354 in 7c3969b

response, err := s.messenger.ValidateTransactions(ctx, wallets)

That verifies transactions from messenger_transactions_to_validate table:

status-go/protocol/persistence.go

Line 1024 in e221047

FROM messenger_transactions_to_validate

When do we save to `messenger_transactions_to_validate` db table?

This function:

status-go/protocol/persistence.go

Lines 975 to 978 in e221047

    
           func (db sqlitePersistence) SaveTransactionToValidate(transaction *TransactionToValidate) error { 
        
           	compressedKey := crypto.CompressPubkey(transaction.From) 
        
           	_, err := db.db.Exec(`INSERT INTO messenger_transactions_to_validate(

... is used only in 1 case

... when we receive ApplicationMetadataMessage_SEND_TRANSACTION message.

When is `SEND_TRANSACTION` used?

And this can be triggered by one of the 2:

AcceptRequestTransaction is an API method.
This goes through a few levels of Nim and appears in QML: AcceptRequestTransaction
... and NOT USED.
SendTransaction is also an API method.
And this doesn't even appear being used in Nim, so... NOT USED.

So I guess this can be dropped. I'll take care of it

…ient

…kens service

* chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0

siddarthkay

changes to go.mod and go.sum look good from devops POV.

osmaczko

🙌 🙌 🙌

dlipicar changed the base branch from develop to feat/replace-old-transfer-detector September 26, 2025 21:05

dlipicar changed the title ~~Chore/drop status go ethereum fork~~ chore: drop status go ethereum fork Sep 26, 2025

igor-sirotin mentioned this pull request Oct 1, 2025

chore: use go-waku with upstream go-ethereum #6978

Merged

dlipicar mentioned this pull request Oct 1, 2025

chore: adapt to new geth logger #6969

Merged

dlipicar force-pushed the feat/replace-old-transfer-detector branch 3 times, most recently from c020188 to bd4386a Compare October 1, 2025 21:23

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from 64516e8 to 391a815 Compare October 1, 2025 21:37

dlipicar force-pushed the feat/replace-old-transfer-detector branch from bd4386a to d064ce0 Compare October 2, 2025 12:06

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from 2f71258 to 79d2d46 Compare October 2, 2025 12:06

dlipicar force-pushed the feat/replace-old-transfer-detector branch 3 times, most recently from c89a9ca to c7fcae5 Compare October 2, 2025 16:24

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from 79d2d46 to 17f7c1a Compare October 2, 2025 16:25

dlipicar force-pushed the feat/replace-old-transfer-detector branch from c7fcae5 to ba10eaa Compare October 2, 2025 16:33

dlipicar force-pushed the feat/replace-old-transfer-detector branch from ba10eaa to 6b24327 Compare October 2, 2025 16:41

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from 17f7c1a to 3e24920 Compare October 2, 2025 16:45

igor-sirotin mentioned this pull request Oct 2, 2025

chore: deprecate command message #6981

Merged

dlipicar force-pushed the feat/replace-old-transfer-detector branch from 6b24327 to 6637db7 Compare October 3, 2025 14:13

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from c7a8bfa to 0ec75ce Compare October 3, 2025 14:13

dlipicar force-pushed the feat/replace-old-transfer-detector branch 2 times, most recently from a1c4195 to c9ab1fe Compare October 3, 2025 18:24

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from 0ec75ce to 5029829 Compare October 3, 2025 18:27

Base automatically changed from feat/replace-old-transfer-detector to develop October 6, 2025 14:27

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from c7131e1 to a54b7fb Compare October 6, 2025 14:29

dlipicar added 2 commits October 6, 2025 11:58

chore: point go.mod to original go-ethereum repo

43a476d

chore: drop usage of non-multichain ethclient methods in rpc chain cl…

6950ec9

…ient

dlipicar and others added 9 commits October 6, 2025 11:59

chore: drop usage of non-multichain ethclient methods in community to…

038a15c

…kens service

chore: drop usage of non-multichain ethclient methods in fees manager

694788f

chore: adapt to new geth logger

d5f42ae

chore: remove unused log_parser code

c991ba1

chore: replace custom NoSign parameter from bind.TransactOpts

8097160

chore: update SingleRequestCodec to go-ethereum upstream

a76d5ad

chore: use go-waku with upstream go-ethereum (#6978)

d98581f

* chore: upgrade go-waku and go-discover * chore: make vendor * feat: go-waku v0.10.0

chore: fix tests

b57f053

chore: bump go-waku and go-discover (#6983)

241278c

dlipicar force-pushed the chore/drop-status-go-ethereum-fork branch from a54b7fb to 241278c Compare October 6, 2025 15:08

dlipicar mentioned this pull request Oct 6, 2025

chore: drop status go ethereum fork status-im/status-desktop#18960

Merged

dlipicar marked this pull request as ready for review October 6, 2025 16:40

dlipicar requested a review from a team as a code owner October 6, 2025 16:40

siddarthkay approved these changes Oct 6, 2025

View reviewed changes

jakubgs approved these changes Oct 7, 2025

View reviewed changes

osmaczko approved these changes Oct 13, 2025

View reviewed changes

dlipicar merged commit b3af095 into develop Oct 13, 2025
24 of 25 checks passed

dlipicar deleted the chore/drop-status-go-ethereum-fork branch October 13, 2025 15:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: drop status go ethereum fork #6961

chore: drop status go ethereum fork #6961

Uh oh!

dlipicar commented Sep 26, 2025 •

edited

Loading

Uh oh!

status-im-auto commented Sep 26, 2025 •

edited

Loading

Uh oh!

codecov bot commented Sep 26, 2025 •

edited

Loading

Uh oh!

igor-sirotin commented Oct 2, 2025 •

edited

Loading

Uh oh!

siddarthkay left a comment •

edited

Loading

Uh oh!

osmaczko left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

chore: drop status go ethereum fork #6961

chore: drop status go ethereum fork #6961

Uh oh!

Conversation

dlipicar commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

status-im-auto commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Jenkins Builds

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

igor-sirotin commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

When do we save to messenger_transactions_to_validate db table?

When is SEND_TRANSACTION used?

Uh oh!

siddarthkay left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osmaczko left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dlipicar commented Sep 26, 2025 •

edited

Loading

status-im-auto commented Sep 26, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading

igor-sirotin commented Oct 2, 2025 •

edited

Loading

When do we save to `messenger_transactions_to_validate` db table?

When is `SEND_TRANSACTION` used?

siddarthkay left a comment •

edited

Loading